WIP: per provider config #177
Draft
+307
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I like the idea, but I think loading the tool into the opencode tool registry just for it to return "don't use this tool" if used is way too hacky and is a permanent performance degradation for any models where it's disabled. Is there maybe a way to do this in a similar way to the opencode config modifications being done to add prune to primary tools so it's not used in subagents? Otherwise, this may need an opencode PR first... |
Contributor
Author
|
Yeah this was moreso just a theory especially without any tool-plugin pipeline to hook into. I think this is still worth pursuing so I'll keep this updated if I find an alternative approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft because it's not a clean impl (see below).
I've been looking into this as I really like the concept of per-provider configuration of this plugin, but @Tarquinen 's initial conclusion in #77 is spot on. We're able to adjust how the plugin functions at runtime BUT are stuck with the
prunetool being loaded into context regardless of whether it's disabled in the plugin config due to opencode's constraints. I did experiment withMessageV2.User.toolsbut it's unreliable. Remediating this behavior might include a tool hook fortools.enabled, or maybe generalprovider.toolconfig in OC (kinda messy/immediate fix).Example
dcp.jsonc{ "enabled": true, "debug": true, "pruningSummary": "detailed", "overrides": { "provider": { "openai": { "enabled": true, "strategies": { "pruneTool": { "enabled": false }, "deduplication": { "enabled": true }, "supersedeWrites": { "enabled": true }, "onIdle": { "enabled": true } } }, "azure": { "enabled": false }, "anthropic": { "enabled": true, "strategies": { "pruneTool": { "enabled": true, "frequency": 10 }, "deduplication": { "enabled": false }, "supersedeWrites": { "enabled": false }, "onIdle": { "enabled": false } } } } }, "strategies": { "deduplication": { "enabled": true, "protectedTools": [ "custom_tool_1" ] }, "supersedeWrites": { "enabled": true }, "pruneTool": { "enabled": true, "protectedTools": [ "custom_tool_2" ], "nudge": { "enabled": true, "frequency": 5 } }, "onIdle": { "enabled": true, "protectedTools": [], "showModelErrorToasts": true, "strictModelSelection": false } } }